-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support sepolia #147
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Please check this PR. #136 closed |
@aahna-ashina I'm wondering what is the cohort address for sepolia? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
const apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY; //mainnet | ||
let apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY; | ||
if (chain?.id == 11155111) { | ||
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY_SEPOLIA; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY_SEPOLIA; | |
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY; |
export const arbitratorAddress = "0xBe67cEdCD1FE38aac8a5781A51250FDeFB344E6C"; | ||
export const cohortAddress = "0xfbb66bc799308435ed2a0e0c0ac3ad1d46749b7b"; | ||
export const safeTxServiceUrl = "https://safe-transaction-sepolia.safe.global"; | ||
export const subgraphURI = process.env.NEXT_PUBLIC_GRAPH_API_URL_SEPOLIA; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const subgraphURI = process.env.NEXT_PUBLIC_GRAPH_API_URL_SEPOLIA; | |
export const subgraphURI = process.env.NEXT_PUBLIC_GRAPH_API_URL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that https://agreements.nation3.org/ supports only the Ethereum mainnet, and https://sepolia.agreements.nation3.org/ supports only the Sepolia testnet, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't support network switching?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't support network switching?
We can still support it, by redirecting to the other URLs. If a user opens https://agreements.nation3.org and selects Sepolia in the chain selection drop-down, we can redirect to https://agreements-sepolia.nation3.org
Sorry, I don't know what the |
@aahna-ashina this is cohort address on mainnet |
Okay, so a cohort will always be a Gnosis safe? I just don't understand the meaning of "cohort" in this context. The variable should have a different name so that everyone can understand what it's for. Can we rename it to something more meaningful? (Can be done in a separate pull request.) |
#135